mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 23:17:45 +00:00
LibJS: Add ECMA-262 section/title/URL comments almost everywhere
As mentioned on Discord earlier, we'll add these to all new functions going forward - this is the backfill. Reasons: - It makes you look at the spec, implementing based on MDN or V8 behavior is a no-go - It makes finding the various functions that are non-compliant easier, in the future everything should either have such a comment or, if it's not from the spec at all, a comment explaining why that is the case - It makes it easier to check whether a certain abstract operation is implemented in LibJS, not all of them use the same name as the spec. E.g. RejectPromise() is Promise::reject() - It makes it easier to reason about vm.arguments(), e.g. when the function has a rest parameter - It makes it easier to see whether a certain function is from a proposal or Annex B Also: - Add arguments to all functions and abstract operations that already had a comment - Fix some outdated section numbers - Replace some ecma-international.org URLs with tc39.es
This commit is contained in:
parent
322c8a3995
commit
7327a28ccc
52 changed files with 480 additions and 101 deletions
|
@ -13,6 +13,7 @@
|
|||
|
||||
namespace JS {
|
||||
|
||||
// 10.5.14 ProxyCreate ( target, handler ), https://tc39.es/ecma262/#sec-proxycreate
|
||||
static ProxyObject* proxy_create(GlobalObject& global_object, Value target, Value handler)
|
||||
{
|
||||
auto& vm = global_object.vm();
|
||||
|
@ -45,6 +46,7 @@ ProxyConstructor::~ProxyConstructor()
|
|||
{
|
||||
}
|
||||
|
||||
// 28.2.1.1 Proxy ( target, handler ), https://tc39.es/ecma262/#sec-proxy-target-handler
|
||||
Value ProxyConstructor::call()
|
||||
{
|
||||
auto& vm = this->vm();
|
||||
|
@ -52,20 +54,21 @@ Value ProxyConstructor::call()
|
|||
return {};
|
||||
}
|
||||
|
||||
// 28.2.1.1 Proxy ( target, handler ), https://tc39.es/ecma262/#sec-proxy-target-handler
|
||||
Value ProxyConstructor::construct(Function&)
|
||||
{
|
||||
auto& vm = this->vm();
|
||||
return proxy_create(global_object(), vm.argument(0), vm.argument(1));
|
||||
}
|
||||
|
||||
// 28.2.2.1 Proxy.revocable, https://tc39.es/ecma262/multipage/reflection.html#sec-proxy.revocable
|
||||
// 28.2.2.1 Proxy.revocable ( target, handler ), https://tc39.es/ecma262/#sec-proxy.revocable
|
||||
JS_DEFINE_NATIVE_FUNCTION(ProxyConstructor::revocable)
|
||||
{
|
||||
auto* proxy = proxy_create(global_object, vm.argument(0), vm.argument(1));
|
||||
if (vm.exception())
|
||||
return {};
|
||||
|
||||
// 28.2.2.1.1 Proxy Revocation Functions, https://tc39.es/ecma262/multipage/reflection.html#sec-proxy-revocation-functions
|
||||
// 28.2.2.1.1 Proxy Revocation Functions, https://tc39.es/ecma262/#sec-proxy-revocation-functions
|
||||
auto* revoker = NativeFunction::create(global_object, "", [proxy_handle = make_handle(proxy)](auto&, auto&) -> Value {
|
||||
auto& proxy = const_cast<ProxyObject&>(*proxy_handle.cell());
|
||||
if (proxy.is_revoked())
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue