RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 22:17:44 +00:00
Code Issues Activity Actions

LibRegex: Disallow duplicate named capture groups in ECMA262 parser

Browse source
This commit is contained in:
davidot 2021-12-19 02:31:21 +01:00 • committed by Linus Groh
parent be3b806487
commit 733a70671b
4 changed files with 11 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibRegex/RegexError.h
View file

@ -35,6 +35,7 @@ enum class Error : u8 {
InvalidCaptureGroup = __Regex_InvalidCaptureGroup, // Content of capture group is invalid.
InvalidNameForCaptureGroup = __Regex_InvalidNameForCaptureGroup, // Name of capture group is invalid.
InvalidNameForProperty = __Regex_InvalidNameForProperty, // Name of property is invalid.
DuplicateNamedCapture = __Regex_DuplicateNamedCapture, // Name of property is invalid.
};
inline String get_error_string(Error error)
@ -76,6 +77,8 @@ inline String get_error_string(Error error)
return "Name of capture group is invalid.";
case Error::InvalidNameForProperty:
return "Name of property is invalid.";
case Error::DuplicateNamedCapture:
return "Duplicate capture group name";
}
return "Undefined error.";
}

5
Userland/Libraries/LibRegex/RegexParser.cpp
View file

@ -2166,6 +2166,11 @@ bool ECMA262Parser::parse_capture_group(ByteCode& stack, size_t& match_length_mi
return false;
}
if (m_parser_state.named_capture_groups.contains(name)) {
set_error(Error::DuplicateNamedCapture);
return false;
}
ByteCode capture_group_bytecode;
size_t length = 0;
enter_capture_group_scope();