RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 17:28:11 +00:00
Code Issues Activity Actions

LibWeb: Expose Parser::Function name as FlyString const&

Browse source 
This saves us from having to re-convert the StringView back to a
FlyString again when resolving UnresolvedStyleValues.
This commit is contained in:
Sam Atkins 2023-09-04 10:50:42 +01:00 • committed by Andreas Kling
parent f527e55046
commit 733ad57f39
3 changed files with 5 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibWeb/CSS/StyleComputer.cpp
View file

@ -1140,8 +1140,7 @@ bool StyleComputer::expand_unresolved_values(DOM::Element& element, StringView p
Parser::TokenStream source_function_contents { source_function.values() };
if (!expand_unresolved_values(element, property_name, source_function_contents, function_values))
return false;
// FIXME: This would be much nicer if we could access the source_function's FlyString value directly.
NonnullRefPtr<Parser::Function> function = Parser::Function::create(FlyString::from_utf8(source_function.name()).release_value_but_fixme_should_propagate_errors(), move(function_values));
NonnullRefPtr<Parser::Function> function = Parser::Function::create(source_function.name(), move(function_values));
dest.empend(function);
continue;
}