From 736f9f38ae33d4a3140a4aff08c10f9d1689bfce Mon Sep 17 00:00:00 2001 From: Liav A Date: Tue, 7 Mar 2023 22:37:06 +0200 Subject: [PATCH] Kernel/Storage: Remove indication for possible future support of ATAPI There's no plan to support ATAPI in the foreseeable future. ATAPI is considered mostly as an extension to pass SCSI commands over ATA-link compatible channel (which could be a physical SATA or PATA). ATAPI is mostly used for controlling optical drives which are considered obsolete in 2023, and require an entire SCSI abstraction layer we don't exhibit with bypassing ioctls for sending specific SCSI commands in many control-flow sequences for actions being taken for such hardware. Therefore, let's make it clear we don't support ATAPI (SCSI over ATA) unless someone picks it up and proves otherwise that this can be done cleanly and also in a relevant way to our project. --- Kernel/Storage/ATA/AHCI/Port.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Kernel/Storage/ATA/AHCI/Port.cpp b/Kernel/Storage/ATA/AHCI/Port.cpp index 33f6e787e9..2760dff2db 100644 --- a/Kernel/Storage/ATA/AHCI/Port.cpp +++ b/Kernel/Storage/ATA/AHCI/Port.cpp @@ -290,7 +290,7 @@ bool AHCIPort::initialize() } m_connected_device = ATADiskDevice::create(*controller, { m_port_index, 0 }, 0, logical_sector_size, max_addressable_sector); } else { - dbgln("AHCI Port {}: Ignoring ATAPI devices for now as we don't currently support them.", representative_port_index()); + dbgln("AHCI Port {}: Ignoring ATAPI devices as we don't support them.", representative_port_index()); } } return true;