RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-05 10:37:34 +00:00
Code Issues Activity Actions

GTextEditor: Improve cursor positioning accuracy when using a mouse.

Browse source 
Put the cursor on the left or right side of a glyph when clicking it based
on distance to middle of glyphs. This is such an obvious change that makes
a small but noticeable difference in feel. :^)
This commit is contained in:
Andreas Kling 2019-04-25 02:15:45 +02:00
parent 7a5525edf4
commit 737315c228
1 changed files with 4 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

7
LibGUI/GTextEditor.cpp
View file

@ -107,6 +107,8 @@ GTextPosition GTextEditor::text_position_at(const Point& a_position) const
auto position = a_position;
position.move_by(horizontal_scrollbar().value(), vertical_scrollbar().value());
position.move_by(-(m_horizontal_content_padding + ruler_width()), 0);
position.move_by(-frame_thickness(), -frame_thickness());
int line_index = position.y() / line_height();
line_index = max(0, min(line_index, line_count() - 1));
auto& line = *m_lines[line_index];
@ -114,16 +116,15 @@ GTextPosition GTextEditor::text_position_at(const Point& a_position) const
int column_index;
switch (m_text_alignment) {
case TextAlignment::CenterLeft:
column_index = position.x() / glyph_width();
column_index = (position.x() + glyph_width() / 2) / glyph_width();
break;
case TextAlignment::CenterRight:
column_index = (position.x() - (content_width() - (line.length() * glyph_width()))) / glyph_width();
column_index = (position.x() - content_x_for_position({ line_index, 0 }) + glyph_width() / 2) / glyph_width();
break;
default:
ASSERT_NOT_REACHED();
}
column_index = max(0, min(column_index, m_lines[line_index]->length()));
return { line_index, column_index };
}