RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 16:27:35 +00:00
Code Issues Activity Actions

LibWeb: Fix nodeName attribute in tests

Browse source 
Commit 19731fc14c (#6864) made all nodeName attributes on HTML elements
uppercased. This change fixes that in all HTML & DOM tests.
This commit is contained in:
Adam Hodgen 2021-05-09 16:42:15 +01:00 • committed by Andreas Kling
parent 37685b0181
commit 737f6e97b2
7 changed files with 12 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Tests/DOM/document.documentElement.js
View file

@ -5,7 +5,7 @@ afterInitialPageLoad(() => {
expect(document.documentElement).not.toBeNull(); expect(document.documentElement).not.toBeNull();
// FIXME: Add this in once HTMLHtmlElement's constructor is implemented. // FIXME: Add this in once HTMLHtmlElement's constructor is implemented.
//expect(document.documentElement).toBeInstanceOf(HTMLHtmlElement); //expect(document.documentElement).toBeInstanceOf(HTMLHtmlElement);
expect(document.documentElement.nodeName).toBe("html"); expect(document.documentElement.nodeName).toBe("HTML");
}); });
// FIXME: Add this in once removeChild is implemented. // FIXME: Add this in once removeChild is implemented.

4
Userland/Libraries/LibWeb/Tests/DOM/mixins/NonElementParentNode.js
View file

@ -4,7 +4,7 @@ afterInitialPageLoad(() => {
test("getElementById basics", () => { test("getElementById basics", () => {
const unique = document.getElementById("unique"); const unique = document.getElementById("unique");
expect(unique).not.toBeNull(); expect(unique).not.toBeNull();
expect(unique.nodeName).toBe("div"); expect(unique.nodeName).toBe("DIV");
expect(unique.id).toBe("unique"); expect(unique.id).toBe("unique");
const caseSensitive = document.getElementById("Unique"); const caseSensitive = document.getElementById("Unique");
@ -12,7 +12,7 @@ afterInitialPageLoad(() => {
const firstDuplicate = document.getElementById("dupeId"); const firstDuplicate = document.getElementById("dupeId");
expect(firstDuplicate).not.toBeNull(); expect(firstDuplicate).not.toBeNull();
expect(firstDuplicate.nodeName).toBe("div"); expect(firstDuplicate.nodeName).toBe("DIV");
expect(firstDuplicate.id).toBe("dupeId"); expect(firstDuplicate.id).toBe("dupeId");
expect(firstDuplicate.innerHTML).toBe("First ID"); expect(firstDuplicate.innerHTML).toBe("First ID");
}); });

6
Userland/Libraries/LibWeb/Tests/DOM/mixins/ParentNode.js
View file

@ -4,7 +4,7 @@ afterInitialPageLoad(() => {
test("querySelector basics", () => { test("querySelector basics", () => {
const firstDuplicateElement = document.querySelector(".duplicate"); const firstDuplicateElement = document.querySelector(".duplicate");
expect(firstDuplicateElement).not.toBeNull(); expect(firstDuplicateElement).not.toBeNull();
expect(firstDuplicateElement.nodeName).toBe("div"); expect(firstDuplicateElement.nodeName).toBe("DIV");
expect(firstDuplicateElement.innerHTML).toBe("First"); expect(firstDuplicateElement.innerHTML).toBe("First");
const noElement = document.querySelector(".nonexistent"); const noElement = document.querySelector(".nonexistent");
@ -14,9 +14,9 @@ afterInitialPageLoad(() => {
test("querySelectorAll basics", () => { test("querySelectorAll basics", () => {
const allDuplicates = document.querySelectorAll(".duplicate"); const allDuplicates = document.querySelectorAll(".duplicate");
expect(allDuplicates).toHaveLength(2); expect(allDuplicates).toHaveLength(2);
expect(allDuplicates[0].nodeName).toBe("div"); expect(allDuplicates[0].nodeName).toBe("DIV");
expect(allDuplicates[0].innerHTML).toBe("First"); expect(allDuplicates[0].innerHTML).toBe("First");
expect(allDuplicates[1].nodeName).toBe("div"); expect(allDuplicates[1].nodeName).toBe("DIV");
expect(allDuplicates[1].innerHTML).toBe("Second"); expect(allDuplicates[1].innerHTML).toBe("Second");
const noElements = document.querySelectorAll(".nonexistent"); const noElements = document.querySelectorAll(".nonexistent");

2
Userland/Libraries/LibWeb/Tests/HTML/HTMLElement.js
View file

@ -3,7 +3,7 @@ loadPage("file:///res/html/misc/welcome.html");
afterInitialPageLoad(() => { afterInitialPageLoad(() => {
test("contentEditable attribute", () => { test("contentEditable attribute", () => {
expect(document.body.contentEditable).toBe("inherit"); expect(document.body.contentEditable).toBe("inherit");
expect(document.firstChild.nextSibling.nodeName).toBe("html"); expect(document.firstChild.nextSibling.nodeName).toBe("HTML");
expect(document.firstChild.nextSibling.contentEditable).toBe("true"); expect(document.firstChild.nextSibling.contentEditable).toBe("true");
}); });
}); });

2
Userland/Libraries/LibWeb/Tests/HTML/HTMLTemplateElement.js
View file

@ -14,7 +14,7 @@ afterInitialPageLoad(() => {
expect(template.content.nodeName).toBe("#document-fragment"); expect(template.content.nodeName).toBe("#document-fragment");
const templateDiv = template.content.getElementById("templatediv"); const templateDiv = template.content.getElementById("templatediv");
expect(templateDiv.nodeName).toBe("div"); expect(templateDiv.nodeName).toBe("DIV");
expect(templateDiv.textContent).toBe("Hello template!"); expect(templateDiv.textContent).toBe("Hello template!");
}); });

6
Userland/Libraries/LibWeb/Tests/HTML/document.body.js
View file

@ -5,7 +5,7 @@ afterInitialPageLoad(() => {
expect(document.body).not.toBeNull(); expect(document.body).not.toBeNull();
// FIXME: Add this in once HTMLBodyElement's constructor is implemented. // FIXME: Add this in once HTMLBodyElement's constructor is implemented.
//expect(document.body).toBeInstanceOf(HTMLBodyElement); //expect(document.body).toBeInstanceOf(HTMLBodyElement);
expect(document.body.nodeName).toBe("body"); expect(document.body.nodeName).toBe("BODY");
}); });
// FIXME: Add this in once set_body is fully implemented. // FIXME: Add this in once set_body is fully implemented.
@ -20,7 +20,7 @@ afterInitialPageLoad(() => {
document.body = newBody; document.body = newBody;
expect(document.body).not.toBeNull(); expect(document.body).not.toBeNull();
expect(document.body.nodeName).toBe("body"); expect(document.body.nodeName).toBe("BODY");
// FIXME: Add this in once HTMLBodyElement's constructor is implemented. // FIXME: Add this in once HTMLBodyElement's constructor is implemented.
//expect(document.body).toBeInstanceOf(HTMLBodyElement); //expect(document.body).toBeInstanceOf(HTMLBodyElement);
@ -34,7 +34,7 @@ afterInitialPageLoad(() => {
document.body = newFrameSet; document.body = newFrameSet;
expect(document.body).not.toBeNull(); expect(document.body).not.toBeNull();
expect(document.body.nodeName).toBe("frameset"); expect(document.body.nodeName).toBe("FRAMESET");
// FIXME: Add this in once HTMLFrameSetElement's constructor is implemented. // FIXME: Add this in once HTMLFrameSetElement's constructor is implemented.
//expect(document.body).toBeInstanceOf(HTMLFrameSetElement); //expect(document.body).toBeInstanceOf(HTMLFrameSetElement);

2
Userland/Libraries/LibWeb/Tests/HTML/document.head.js
View file

@ -5,7 +5,7 @@ afterInitialPageLoad(() => {
expect(document.head).not.toBeNull(); expect(document.head).not.toBeNull();
// FIXME: Add this in once HTMLHeadElement's constructor is implemented. // FIXME: Add this in once HTMLHeadElement's constructor is implemented.
//expect(document.head).toBeInstanceOf(HTMLHeadElement); //expect(document.head).toBeInstanceOf(HTMLHeadElement);
expect(document.head.nodeName).toBe("head"); expect(document.head.nodeName).toBe("HEAD");
}); });
// FIXME: Add this in once removeChild is implemented. // FIXME: Add this in once removeChild is implemented.