RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:48:14 +00:00
Code Issues Activity Actions

LibUnicode: Use recently added Core::Stream::read_all in code generators

Browse source 
The generators had a manual implementation when Core::Stream did not
have a read_all method.
This commit is contained in:
Timothy Flynn 2022-09-14 06:32:56 -04:00 • committed by Sam Atkins
parent a5bb30d2ba
commit 739798e075
1 changed files with 2 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Meta/Lagom/Tools/CodeGenerators/LibUnicode/GeneratorUtil.h
View file

@ -332,17 +332,9 @@ inline ErrorOr<NonnullOwnPtr<Core::Stream::BufferedFile>> open_file(StringView p
inline ErrorOr<JsonValue> read_json_file(StringView path)
{
auto file = TRY(open_file(path, Core::Stream::OpenMode::Read));
auto buffer = TRY(file->read_all());
StringBuilder builder;
Array<u8, 4096> buffer;
// FIXME: When Core::Stream supports reading an entire file, use that.
while (TRY(file->can_read_line())) {
auto bytes_read = TRY(file->read(buffer));
TRY(builder.try_append(StringView { bytes_read }));
}
return JsonValue::from_string(builder.build());
return JsonValue::from_string(buffer);
}
inline ErrorOr<Core::DirIterator> path_to_dir_iterator(String path, StringView subpath = "main"sv)