RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 16:27:35 +00:00
Code Issues Activity Actions

LibJS: Convert internal_prevent_extensions() to ThrowCompletionOr

Browse source
This commit is contained in:
Linus Groh 2021-09-29 00:13:41 +01:00
parent 9b4362f10a
commit 73bae7d779
12 changed files with 22 additions and 30 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/Bindings/LocationObject.cpp
View file

@ -140,7 +140,7 @@ JS::ThrowCompletionOr<bool> LocationObject::internal_is_extensible() const
}
// https://html.spec.whatwg.org/multipage/history.html#location-preventextensions
bool LocationObject::internal_prevent_extensions()
JS::ThrowCompletionOr<bool> LocationObject::internal_prevent_extensions()
{
// 1. Return false.
return false;

2
Userland/Libraries/LibWeb/Bindings/LocationObject.h
View file

@ -23,7 +23,7 @@ public:
virtual JS::ThrowCompletionOr<bool> internal_set_prototype_of(Object* prototype) override;
virtual JS::ThrowCompletionOr<bool> internal_is_extensible() const override;
virtual bool internal_prevent_extensions() override;
virtual JS::ThrowCompletionOr<bool> internal_prevent_extensions() override;
// FIXME: There should also be a custom [[GetPrototypeOf]], [[GetOwnProperty]], [[DefineOwnProperty]], [[Get]], [[Set]], [[Delete]] and [[OwnPropertyKeys]],
// but we don't have the infrastructure in place to implement them yet.