RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:27:43 +00:00
Code Issues Activity Actions

LibWeb: Remove many redundant SVGUseElement clone calls

Browse source 
This prevents SVG elements referenced by "use" being repeatedly cloned
in many redundant cases. Pages that use a large svg "sprite" that then
is referenced many times with "use" elements would load extremely
slowly, or crash the page.
This commit is contained in:
Sebastian Zaha 2023-07-12 11:23:33 +02:00 • committed by Andreas Kling
parent d24667a1b6
commit 73f1c7a030
1 changed files with 14 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

16
Userland/Libraries/LibWeb/SVG/SVGElement.cpp
View file

@ -8,6 +8,7 @@
#include <LibWeb/Bindings/ExceptionOrUtils.h>
#include <LibWeb/Bindings/Intrinsics.h>
#include <LibWeb/DOM/Document.h>
#include <LibWeb/DOM/ShadowRoot.h>
#include <LibWeb/HTML/DOMStringMap.h>
#include <LibWeb/SVG/SVGElement.h>
#include <LibWeb/SVG/SVGUseElement.h>
@ -60,7 +61,18 @@ void SVGElement::children_changed()
void SVGElement::update_use_elements_that_reference_this()
{
if (is<SVGUseElement>(this)) {
if (is<SVGUseElement>(this)
// If this element is in a shadow root, it already represents a clone and is not itself referenced.
|| is<DOM::ShadowRoot>(this->root())
// If this does not have an id it cannot be referenced, no point in searching the entire DOM tree.
|| !this->has_attribute(HTML::AttributeNames::id)
// An unconnected node cannot have valid references.
// This also prevents searches for elements that are in the process of being constructed - as clones.
|| !this->is_connected()
// Each use element already listens for the completely_loaded event and then clones its referece,
// we do not have to also clone it in the process of initial DOM building.
|| !document().is_completely_loaded()) {
return;
}
@ -79,7 +91,7 @@ void SVGElement::removed_from(Node* parent)
void SVGElement::remove_from_use_element_that_reference_this()
{
if (is<SVGUseElement>(this)) {
if (is<SVGUseElement>(this) || !this->has_attribute(HTML::AttributeNames::id)) {
return;
}