RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:38:12 +00:00
Code Issues Activity Actions

Kernel+LibVT: Add function for deleting a range of characters

Browse source 
Previously, this was done by telling the client to put a space at each
character in the range. This was inefficient, because a large number of
function calls took place and incorrect, as the ANSI standard dictates
that character attributes should be cleared as well.

The newly added `clear_in_line` function solves this issue. It performs
just one bounds check when it's called and can be implemented as a
pretty tight loop.
This commit is contained in:
Daniel Bertalan 2021-06-05 11:12:00 +02:00 • committed by Andreas Kling
parent 8f8fd9c5a8
commit 7419569a2b
7 changed files with 60 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

18
Kernel/TTY/VirtualConsole.cpp
View file

@ -81,6 +81,11 @@ void ConsoleImpl::put_character_at(unsigned row, unsigned column, u32 ch)
m_last_code_point = ch;
}
void ConsoleImpl::clear_in_line(u16 row, u16 first_column, u16 last_column)
{
m_client.clear_in_line(row, first_column, last_column);
}
void ConsoleImpl::ICH(Parameters)
{
// FIXME: Implement this
@ -420,13 +425,14 @@ void VirtualConsole::scroll_down(u16 region_top, u16 region_bottom, size_t count
m_lines[row].dirty = true;
}
void VirtualConsole::clear_line(size_t y_index)
void VirtualConsole::clear_in_line(u16 row, u16 first_column, u16 last_column)
{
m_lines[y_index].dirty = true;
for (size_t x = 0; x < columns(); x++) {
auto& cell = cell_at(x, y_index);
cell.clear();
}
VERIFY(row < rows());
VERIFY(first_column <= last_column);
VERIFY(last_column < columns());
m_lines[row].dirty = true;
for (size_t x = first_column; x <= last_column; x++)
cell_at(x, row).clear();
}
void VirtualConsole::put_character_at(unsigned row, unsigned column, u32 code_point, const VT::Attribute& attribute)