RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 10:37:45 +00:00
Code Issues Activity Actions

Kernel+LibVT: Add function for deleting a range of characters

Browse source 
Previously, this was done by telling the client to put a space at each
character in the range. This was inefficient, because a large number of
function calls took place and incorrect, as the ANSI standard dictates
that character attributes should be cleared as well.

The newly added `clear_in_line` function solves this issue. It performs
just one bounds check when it's called and can be implemented as a
pretty tight loop.
This commit is contained in:
Daniel Bertalan 2021-06-05 11:12:00 +02:00 • committed by Andreas Kling
parent 8f8fd9c5a8
commit 7419569a2b
7 changed files with 60 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibVT/Attribute.h
View file

@ -15,8 +15,6 @@
namespace VT {
struct Attribute {
Attribute() { reset(); }
static constexpr Color default_foreground_color = Color::named(Color::ANSIColor::DefaultForeground);
static constexpr Color default_background_color = Color::named(Color::ANSIColor::DefaultBackground);
@ -25,12 +23,17 @@ struct Attribute {
foreground_color = default_foreground_color;
background_color = default_background_color;
flags = Flags::NoAttributes;
#ifndef KERNEL
href = {};
href_id = {};
#endif
}
Color foreground_color { default_foreground_color };
Color background_color { default_background_color };
Color effective_background_color() const { return flags & Negative ? foreground_color : background_color; }
Color effective_foreground_color() const { return flags & Negative ? background_color : foreground_color; }
constexpr Color effective_background_color() const { return flags & Negative ? foreground_color : background_color; }
constexpr Color effective_foreground_color() const { return flags & Negative ? background_color : foreground_color; }
#ifndef KERNEL
String href;
@ -47,17 +50,17 @@ struct Attribute {
Touched = 0x20,
};
bool is_untouched() const { return !(flags & Touched); }
constexpr bool is_untouched() const { return !(flags & Touched); }
// TODO: it would be really nice if we had a helper for enums that
// exposed bit ops for class enums...
u8 flags = Flags::NoAttributes;
u8 flags { Flags::NoAttributes };
bool operator==(const Attribute& other) const
constexpr bool operator==(const Attribute& other) const
{
return foreground_color == other.foreground_color && background_color == other.background_color && flags == other.flags;
}
bool operator!=(const Attribute& other) const
constexpr bool operator!=(const Attribute& other) const
{
return !(*this == other);
}