Kernel/Storage: Unify all ATA devices

There's basically no real difference in software between a SATA harddisk
and IDE harddisk. The difference in the implementation is for the host
bus adapter protocol and registers layout.
Therefore, there's no point in putting a distinction in software to
these devices.

This change also greatly simplifies and removes stale APIs and removes
unnecessary parameters in constructor calls, which tighten things
further everywhere.

Kernel/Storage/ATAPIDiscDevice.cpp

@@ -0,0 +1,45 @@
+/*
+ * Copyright (c) 2021, Liav A. <liavalb@hotmail.co.il>
+ *
+ * SPDX-License-Identifier: BSD-2-Clause
+ */
+
+#include <AK/StringView.h>
+#include <Kernel/Devices/DeviceManagement.h>
+#include <Kernel/Sections.h>
+#include <Kernel/Storage/ATAPIDiscDevice.h>
+#include <Kernel/Storage/IDEChannel.h>
+#include <Kernel/Storage/IDEController.h>
+#include <Kernel/Storage/StorageManagement.h>
+
+namespace Kernel {
+
+NonnullRefPtr<ATAPIDiscDevice> ATAPIDiscDevice::create(const ATAController& controller, ATADevice::Address ata_address, u16 capabilities, u64 max_addressable_block)
+{
+    auto minor_device_number = StorageManagement::minor_number();
+
+    // FIXME: We need a way of formatting strings with KString.
+    auto device_name = String::formatted("hd{:c}", 'a' + minor_device_number);
+    auto device_name_kstring = KString::must_create(device_name.view());
+
+    auto disc_device_or_error = DeviceManagement::try_create_device<ATAPIDiscDevice>(controller, ata_address, minor_device_number, capabilities, max_addressable_block, move(device_name_kstring));
+    // FIXME: Find a way to propagate errors
+    VERIFY(!disc_device_or_error.is_error());
+    return disc_device_or_error.release_value();
+}
+
+ATAPIDiscDevice::ATAPIDiscDevice(const ATAController& controller, ATADevice::Address ata_address, unsigned minor_number, u16 capabilities, u64 max_addressable_block, NonnullOwnPtr<KString> early_storage_name)
+    : ATADevice(controller, ata_address, minor_number, capabilities, 0, max_addressable_block, move(early_storage_name))
+{
+}
+
+ATAPIDiscDevice::~ATAPIDiscDevice()
+{
+}
+
+StringView ATAPIDiscDevice::class_name() const
+{
+    return "ATAPIDiscDevice";
+}
+
+}