RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 19:27:35 +00:00
Code Issues Activity Actions

Meta+Userland: Simplify some formatters

Browse source 
These are mostly minor mistakes I've encountered while working on the
removal of StringView(char const*). The usage of builder.put_string over
Format<FormatString>::format is preferrable as it will avoid the
indirection altogether when there's no formatting to be done. Similarly,
there is no need to do format(builder, "{}", number) when
builder.put_u64(number) works equally well.

Additionally a few Strings where only constant strings were used are
replaced with StringViews.
This commit is contained in:
sin-ack 2022-07-11 20:23:24 +00:00 • committed by Andreas Kling
parent 7da00bfa8d
commit 7456904a39
9 changed files with 64 additions and 67 deletions
Download patch file Download diff file Expand all files Collapse all files

5
Userland/Libraries/LibCore/Directory.h
View file

@ -62,8 +62,9 @@ struct Formatter<Core::Directory> : Formatter<StringView> {
{
auto path = directory.path();
if (path.is_error())
return Formatter<StringView>::format(builder, "<unknown>");
return Formatter<StringView>::format(builder, path.release_value().string());
TRY(builder.put_string("<unknown>"sv));
TRY(builder.put_string(path.release_value().string()));
return {};
}
};