RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 12:28:12 +00:00
Code Issues Activity Actions

WebContent: Pre-emptively update viewport offset on request to scroll

Browse source
This commit is contained in:
Aliaksandr Kalenik 2023-12-19 15:51:21 +01:00 • committed by Andreas Kling
parent d361221657
commit 7458c27c4b
1 changed files with 7 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

7
Userland/Services/WebContent/PageClient.cpp
View file

@ -281,6 +281,13 @@ void PageClient::page_did_request_scroll(i32 x_delta, i32 y_delta)
void PageClient::page_did_request_scroll_to(Web::CSSPixelPoint scroll_position) void PageClient::page_did_request_scroll_to(Web::CSSPixelPoint scroll_position)
{ {
// NOTE: The viewport scroll position is updated preemptively, so that subsequent
// viewport offset calculation could use new offset even before actual
// scroll on browser side happens.
auto viewport = page().top_level_traversable()->viewport_rect();
viewport.set_location(scroll_position);
page().top_level_traversable()->set_viewport_rect(viewport);
auto device_scroll_position = page().css_to_device_point(scroll_position); auto device_scroll_position = page().css_to_device_point(scroll_position);
client().async_did_request_scroll_to(device_scroll_position.to_type<int>()); client().async_did_request_scroll_to(device_scroll_position.to_type<int>());
} }