RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 13:18:13 +00:00
Code Issues Activity Actions

LibWeb: Make WebDriver check if the BC's navigable has been destroyed

Browse source 
The spec steps to check if a browsing context is open have been updated
for navigables.
This commit is contained in:
Timothy Flynn 2024-02-05 12:34:29 -05:00 • committed by Andreas Kling
parent 623ad94582
commit 747fd86f26
4 changed files with 12 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/WebDriver/ExecuteScript.cpp
View file

@ -115,9 +115,9 @@ static ErrorOr<JsonValue, ExecuteScriptResultType> internal_json_clone_algorithm
if (is<HTML::WindowProxy>(value.as_object())) {
auto const& window_proxy = static_cast<HTML::WindowProxy&>(value.as_object());
// If the associated browsing context of the WindowProxy object in value has been discarded, return error with
// If the associated browsing context of the WindowProxy object in value has been destroyed, return error with
// error code stale element reference.
if (window_proxy.associated_browsing_context()->has_been_discarded())
if (window_proxy.associated_browsing_context()->has_navigable_been_destroyed())
return ExecuteScriptResultType::BrowsingContextDiscarded;
// Otherwise return success with data set to WindowProxy reference object for value.