RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 16:22:43 +00:00
Code Issues Activity Actions

Kernel: Avoid some un-necessary copies coming from range based for loops

Browse source 
- The irq_controller was getting add_ref/released needlessly during enumeration.

- Used ranges were also getting needlessly copied.
This commit is contained in:
Brian Gianforcaro 2021-02-15 03:56:39 -08:00 • committed by Andreas Kling
parent a5f879ea8c
commit 7482cb6531
2 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Kernel/VM/MemoryManager.cpp
View file

@ -195,7 +195,7 @@ void MemoryManager::parse_memory_map()
auto* mmap_begin = reinterpret_cast<multiboot_memory_map_t*>(low_physical_to_virtual(multiboot_info_ptr->mmap_addr));
auto* mmap_end = reinterpret_cast<multiboot_memory_map_t*>(low_physical_to_virtual(multiboot_info_ptr->mmap_addr) + multiboot_info_ptr->mmap_length);
for (auto used_range : m_used_memory_ranges) {
for (auto& used_range : m_used_memory_ranges) {
klog() << "MM: " << used_range;
}
@ -255,7 +255,7 @@ void MemoryManager::parse_memory_map()
// Skip used memory ranges.
bool should_skip = false;
for (auto used_range : m_used_memory_ranges) {
for (auto& used_range : m_used_memory_ranges) {
if (addr.get() >= used_range.start.get() && addr.get() <= used_range.end.get()) {
should_skip = true;
break;