RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 00:47:45 +00:00
Code Issues Activity Actions

LibGfx: Remove unused BMPWriter::set_compression()

Browse source 
This has always been unused, and after #8440 BMPWriter::dump()
unconditionally writes to m_compression, meaning even if this
method was called, it would have no effect.
This commit is contained in:
Nico Weber 2023-03-12 10:21:29 -04:00 • committed by Jelle Raaijmakers
parent 7bb7d87807
commit 74891ab656
2 changed files with 9 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibGfx/BMPWriter.cpp
View file

@ -67,7 +67,7 @@ static ByteBuffer write_pixel_data(RefPtr<Bitmap const> bitmap, int pixel_row_da
return buffer; return buffer;
} }
static ByteBuffer compress_pixel_data(ByteBuffer const& pixel_data, BMPWriter::Compression compression) ByteBuffer BMPWriter::compress_pixel_data(ByteBuffer const& pixel_data, BMPWriter::Compression compression)
{ {
switch (compression) { switch (compression) {
case BMPWriter::Compression::BI_BITFIELDS: case BMPWriter::Compression::BI_BITFIELDS:

15
Userland/Libraries/LibGfx/BMPWriter.h
View file

@ -16,11 +16,6 @@ class BMPWriter {
public: public:
BMPWriter() = default; BMPWriter() = default;
enum class Compression : u32 {
BI_RGB = 0,
BI_BITFIELDS = 3,
};
enum class DibHeader : u32 { enum class DibHeader : u32 {
Info = 40, Info = 40,
V3 = 56, V3 = 56,
@ -29,10 +24,16 @@ public:
ByteBuffer dump(RefPtr<Bitmap const>, DibHeader dib_header = DibHeader::V4); ByteBuffer dump(RefPtr<Bitmap const>, DibHeader dib_header = DibHeader::V4);
inline void set_compression(Compression compression) { m_compression = compression; }
private: private:
enum class Compression : u32 {
BI_RGB = 0,
BI_BITFIELDS = 3,
};
static ByteBuffer compress_pixel_data(ByteBuffer const&, Compression);
Compression m_compression { Compression::BI_BITFIELDS }; Compression m_compression { Compression::BI_BITFIELDS };
int m_bytes_per_pixel { 4 }; int m_bytes_per_pixel { 4 };
bool m_include_alpha_channel { true }; bool m_include_alpha_channel { true };
}; };