RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 03:37:43 +00:00
Code Issues Activity Actions

LibGfx: Minor IntRect::shatter and FloatRect::shatter optimization

Browse source 
All the shards always intersect unless they're empty.
So rather than checking for intersection, just check
whether they're empty or not.
This commit is contained in:
Tom 2020-07-14 10:15:56 -06:00 • committed by Andreas Kling
parent cd8495f1d4
commit 7498024805
2 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Libraries/LibGfx/FloatRect.cpp
View file

@ -96,13 +96,13 @@ Vector<FloatRect, 4> FloatRect::shatter(const FloatRect& hammer) const
right() - hammer.right(), right() - hammer.right(),
min((hammer.y() + hammer.height()), (y() + height())) - max(hammer.y(), y()) min((hammer.y() + hammer.height()), (y() + height())) - max(hammer.y(), y())
}; };
if (intersects(top_shard)) if (!top_shard.is_empty())
pieces.unchecked_append(top_shard); pieces.unchecked_append(top_shard);
if (intersects(bottom_shard)) if (!bottom_shard.is_empty())
pieces.unchecked_append(bottom_shard); pieces.unchecked_append(bottom_shard);
if (intersects(left_shard)) if (!left_shard.is_empty())
pieces.unchecked_append(left_shard); pieces.unchecked_append(left_shard);
if (intersects(right_shard)) if (!right_shard.is_empty())
pieces.unchecked_append(right_shard); pieces.unchecked_append(right_shard);
return pieces; return pieces;

8
Libraries/LibGfx/Rect.cpp
View file

@ -97,13 +97,13 @@ Vector<IntRect, 4> IntRect::shatter(const IntRect& hammer) const
right() - hammer.right(), right() - hammer.right(),
min((hammer.y() + hammer.height()), (y() + height())) - max(hammer.y(), y()) min((hammer.y() + hammer.height()), (y() + height())) - max(hammer.y(), y())
}; };
if (intersects(top_shard)) if (!top_shard.is_empty())
pieces.unchecked_append(top_shard); pieces.unchecked_append(top_shard);
if (intersects(bottom_shard)) if (!bottom_shard.is_empty())
pieces.unchecked_append(bottom_shard); pieces.unchecked_append(bottom_shard);
if (intersects(left_shard)) if (!left_shard.is_empty())
pieces.unchecked_append(left_shard); pieces.unchecked_append(left_shard);
if (intersects(right_shard)) if (!right_shard.is_empty())
pieces.unchecked_append(right_shard); pieces.unchecked_append(right_shard);
return pieces; return pieces;