RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 08:48:11 +00:00
Code Issues Activity Actions

LibHTML: Add LayoutNodeWithStyle class, make LayoutText style-less

Browse source 
Since LayoutText always inherits style, it shouldn't store any style of
its own. This patch adds a LayoutNodeWithStyle class to sit between
LayoutNode and everyone who wants to inherit from LayoutNode except
LayoutText :^)

Since LayoutText can never have children, we also know that the parent
of any LayoutNode is always going to be a LayoutNodeWithStyle.
So this patch makes LayoutNode::parent() return LayoutNodeWithStyle*.
This commit is contained in:
Andreas Kling 2019-10-07 09:50:31 +02:00
parent 15f3e64862
commit 749e3f0f30
9 changed files with 46 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Libraries/LibHTML/Layout/LayoutBlock.cpp
View file

@ -5,7 +5,7 @@
#include <LibHTML/Layout/LayoutInline.h>
LayoutBlock::LayoutBlock(const Node* node, NonnullRefPtr<StyleProperties> style)
: LayoutNode(node, move(style))
: LayoutNodeWithStyle(node, move(style))
{
}