RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 14:27:35 +00:00
Code Issues Activity Actions

LibWeb: Update SVG <circle> element to use geometry properties

Browse source 
With this the `<circle>` element now correctly parses percentage sizes,
and resolves them relative to the viewport.

The rest of the geometry elements are still left TODO.
This commit is contained in:
MacDue 2024-03-03 20:47:10 +00:00 • committed by Andreas Kling
parent 344eb98b3c
commit 74b655d035
6 changed files with 71 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibWeb/SVG/SVGCircleElement.h
View file

@ -18,7 +18,7 @@ class SVGCircleElement final : public SVGGeometryElement {
public:
virtual ~SVGCircleElement() override = default;
virtual void attribute_changed(FlyString const& name, Optional<String> const& value) override;
virtual void apply_presentational_hints(CSS::StyleProperties&) const override;
virtual Gfx::Path get_path(CSSPixelSize viewport_size) override;
@ -30,10 +30,6 @@ private:
SVGCircleElement(DOM::Document&, DOM::QualifiedName);
virtual void initialize(JS::Realm&) override;
Optional<float> m_center_x;
Optional<float> m_center_y;
Optional<float> m_radius;
};
}