RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-25 22:15:06 +00:00
Code Issues Activity Actions

LibC: Use u32 in arc4random instead of char[4]

Browse source 
There's no alignment requirements on a char[4] buffer, so this was
causing unaligned reads that were caught by UBSAN.
This commit is contained in:
Andrew Kaster 2021-05-24 08:21:59 -06:00 • committed by Andreas Kling
parent 1a0eed705c
commit 74da0f24f0
1 changed files with 3 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Userland/Libraries/LibC/stdlib.cpp
View file

@ -1080,9 +1080,9 @@ unsigned long long strtoull(const char* str, char** endptr, int base)
// TODO: In the future, rand can be made deterministic and this not. // TODO: In the future, rand can be made deterministic and this not.
uint32_t arc4random(void) uint32_t arc4random(void)
{ {
char buf[4]; uint32_t buf;
syscall(SC_getrandom, buf, 4, 0); syscall(SC_getrandom, &buf, sizeof(buf), 0);
return *(uint32_t*)buf; return buf;
} }
void arc4random_buf(void* buffer, size_t buffer_size) void arc4random_buf(void* buffer, size_t buffer_size)