RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-16 15:34:58 +00:00
Code Issues Activity Actions

Kernel: Avoid some allocations in command line parsing (#3213)

Browse source 
1. Preallocate args hashmap to prevent rehashing.
2. Use move to prevent string copies.
This commit is contained in:
Muhammad Zahalqa 2020-08-23 16:04:49 +03:00 • committed by GitHub
parent 1b075ffe3b
commit 7506adbece
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
1 changed files with 5 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/CommandLine.cpp
View file

@ -46,7 +46,9 @@ CommandLine::CommandLine(const String& string)
{
s_the = this;
for (auto str : m_string.split(' ')) {
const auto& args = m_string.split(' ');
m_params.ensure_capacity(args.size());
for (auto&& str : args) {
if (str == "") {
continue;
}
@ -54,9 +56,9 @@ CommandLine::CommandLine(const String& string)
auto pair = str.split_limit('=', 2);
if (pair.size() == 1) {
m_params.set(pair[0], "");
m_params.set(move(pair[0]), "");
} else {
m_params.set(pair[0], pair[1]);
m_params.set(move(pair[0]), move(pair[1]));
}
}
}