RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:47:44 +00:00
Code Issues Activity Actions

FileDescription: Disallow construction with a null File

Browse source 
It's not valid for a FileDescription to not have a file, so let's
disallow it by taking a File& (or FIFO&) in the constructor.
This commit is contained in:
Andreas Kling 2019-08-11 09:32:21 +02:00
parent 0dc05a33c1
commit 752de9cd27
6 changed files with 18 additions and 19 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Kernel/FileSystem/FileDescription.h
View file

@ -22,8 +22,8 @@ class SharedMemory;
class FileDescription : public RefCounted<FileDescription> {
public:
static NonnullRefPtr<FileDescription> create(RefPtr<Custody>&&);
static NonnullRefPtr<FileDescription> create(RefPtr<File>, SocketRole = SocketRole::None);
static NonnullRefPtr<FileDescription> create(Custody&);
static NonnullRefPtr<FileDescription> create(File&, SocketRole = SocketRole::None);
~FileDescription();
NonnullRefPtr<FileDescription> clone();
@ -106,12 +106,12 @@ public:
private:
friend class VFS;
FileDescription(RefPtr<File>&&, SocketRole = SocketRole::None);
FileDescription(File&, SocketRole = SocketRole::None);
FileDescription(FIFO&, FIFO::Direction);
RefPtr<Custody> m_custody;
RefPtr<Inode> m_inode;
RefPtr<File> m_file;
NonnullRefPtr<File> m_file;
off_t m_current_offset { 0 };