RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:57:34 +00:00
Code Issues Activity Actions

LibDebug: Fix truncation in ExtendedOpcodes::SetDiscriminator

Browse source 
The parameter of this operator is an unsigned LEB128 integer, so it can
be more than 1 byte in length. If we only read 1 byte, we might mess up
the offsets for the instructions following it.
This commit is contained in:
Daniel Bertalan 2021-12-05 07:52:53 +01:00 • committed by Brian Gianforcaro
parent d3f5416b70
commit 7546295abe
1 changed files with 2 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

3
Userland/Libraries/LibDebug/Dwarf/LineProgram.cpp
View file

@ -170,7 +170,8 @@ void LineProgram::handle_extended_opcode()
} }
case ExtendedOpcodes::SetDiscriminator: { case ExtendedOpcodes::SetDiscriminator: {
dbgln_if(DWARF_DEBUG, "SetDiscriminator"); dbgln_if(DWARF_DEBUG, "SetDiscriminator");
m_stream.discard_or_error(1); size_t discriminator;
m_stream.read_LEB128_unsigned(discriminator);
break; break;
} }
default: default: