RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-10-31 17:32:44 +00:00
Code Issues Activity Actions

SystemServer: chown all available TTY devices to the tty group

Browse source 
Since we have 6 TTYs available 2 of the 6 were not being chowned and as
such they were not available to the tty group.
This commit is contained in:
Idan Horowitz 2021-03-29 18:59:51 +03:00 • committed by Andreas Kling
parent b88de8a91f
commit 754f87875f
1 changed files with 3 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Services/SystemServer/main.cpp
View file

@ -125,11 +125,13 @@ static void prepare_devfs()
// FIXME: Find a better way to chown without hardcoding the gid! // FIXME: Find a better way to chown without hardcoding the gid!
chown_wrapper("/dev/mouse", 0, 3); chown_wrapper("/dev/mouse", 0, 3);
for (size_t index = 0; index < 4; index++) { // FIXME: Count TTYs instead of using a hardcoded amount
for (size_t index = 0; index < 6; index++) {
// FIXME: Find a better way to chown without hardcoding the gid! // FIXME: Find a better way to chown without hardcoding the gid!
chown_wrapper(String::formatted("/dev/tty{}", index).characters(), 0, 2); chown_wrapper(String::formatted("/dev/tty{}", index).characters(), 0, 2);
} }
// FIXME: Count serial TTYs instead of using a hardcoded amount
for (size_t index = 0; index < 4; index++) { for (size_t index = 0; index < 4; index++) {
// FIXME: Find a better way to chown without hardcoding the gid! // FIXME: Find a better way to chown without hardcoding the gid!
chown_wrapper(String::formatted("/dev/ttyS{}", index).characters(), 0, 2); chown_wrapper(String::formatted("/dev/ttyS{}", index).characters(), 0, 2);