RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:27:45 +00:00
Code Issues Activity Actions

Ports: Sanitize environment before handling Ports

Browse source 
This keeps users from leaking their host environment variables (CFLAGS,
etc.) into Ports, and it keeps us from leaking Port-specific settings
into their dependencies.
This commit is contained in:
Tim Schumacher 2022-05-19 23:28:43 +02:00 • committed by Andreas Kling
parent bdac8c53ea
commit 7550017f97
3 changed files with 15 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

1
Meta/lint-ports.py
View file

@ -21,6 +21,7 @@ PORT_TABLE_FILE = 'AvailablePorts.md'
IGNORE_FILES = { IGNORE_FILES = {
'.gitignore', '.gitignore',
'.port_include.sh', '.port_include.sh',
'.strip_env.sh',
PORT_TABLE_FILE, PORT_TABLE_FILE,
'build_all.sh', 'build_all.sh',
'build_installed.sh', 'build_installed.sh',

6
Ports/.port_include.sh
View file

@ -2,6 +2,12 @@
set -eu set -eu
SCRIPT="$(dirname "${0}")" SCRIPT="$(dirname "${0}")"
if [ -z "${SERENITY_STRIPPED_ENV:-}" ]; then
exec "${SCRIPT}/.strip_env.sh" "${@}"
fi
unset SERENITY_STRIPPED_ENV
export MAKEJOBS="${MAKEJOBS:-$(nproc)}" export MAKEJOBS="${MAKEJOBS:-$(nproc)}"
maybe_source() { maybe_source() {

8
Ports/.strip_env.sh Executable file
View file

@ -0,0 +1,8 @@
#!/usr/bin/env bash
exec env -i SERENITY_STRIPPED_ENV=1 \
MAKEJOBS="${MAKEJOBS:-}" \
IN_SERENITY_PORT_DEV="${IN_SERENITY_PORT_DEV:-}" \
SERENITY_ARCH="${SERENITY_ARCH:-}" \
SERENITY_TOOLCHAIN="${SERENITY_TOOLCHAIN:-}" \
"${@}"