From 755fe2b0ca9db18e7e433f5dd86081796a0b0778 Mon Sep 17 00:00:00 2001 From: Karol Kosek Date: Sat, 31 Jul 2021 23:40:25 +0200 Subject: [PATCH] FileManager: Remove the rename action from the tree view context menu The action never worked properly here. It used the selection from the directory view, instead of the tree view. Furthermore, the tree view isn't even editable. Just making tree view editable wouldn't fix it -- it'd probably need something like creating an on_stop_editing() function in the AbstractView to change the path after the rename. For now, I'll remove the action from the menu as a "temporary fix". --- Userland/Applications/FileManager/main.cpp | 1 - 1 file changed, 1 deletion(-) diff --git a/Userland/Applications/FileManager/main.cpp b/Userland/Applications/FileManager/main.cpp index 20cf7e4586..3db2e92247 100644 --- a/Userland/Applications/FileManager/main.cpp +++ b/Userland/Applications/FileManager/main.cpp @@ -1057,7 +1057,6 @@ int run_in_windowed_mode(RefPtr config, String initial_locatio tree_view_directory_context_menu->add_action(copy_action); tree_view_directory_context_menu->add_action(paste_action); tree_view_directory_context_menu->add_action(tree_view_delete_action); - tree_view_directory_context_menu->add_action(directory_view.rename_action()); tree_view_directory_context_menu->add_separator(); tree_view_directory_context_menu->add_action(properties_action); tree_view_directory_context_menu->add_separator();