RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 00:17:46 +00:00
Code Issues Activity Actions

AK/StringUtils: Ensure needle positions don't overlap in replace

Browse source 
Previously, `replace` used `find_all` to find all of the positions to
replace. But `find_all` finds all the *overlapping* instances of the
needle, while `replace` assumed that the next position was always at
least `needle.length()` away from the last one. This led to crashes like
https://github.com/SerenityOS/jakt/issues/1159.
This commit is contained in:
Jesús "gsus" Lapastora 2023-12-17 17:52:45 +01:00 • committed by Andrew Kaster
parent 5e1499d104
commit 7578620f25
2 changed files with 69 additions and 42 deletions
Download patch file Download diff file Expand all files Collapse all files

20
Tests/AK/TestStringUtils.cpp
View file

@ -407,6 +407,26 @@ TEST_CASE(find)
EXPECT_EQ(AK::StringUtils::find(test_string, "78"sv).has_value(), false);
}
TEST_CASE(replace_all_overlapping)
{
// Replace only should take into account non-overlapping instances of the
// needle, since it is looking to replace them.
// These samples were grabbed from ADKaster's sample code in
// https://github.com/SerenityOS/jakt/issues/1159. This is the equivalent
// C++ code that triggered the same bug from Jakt's code generator.
auto const replace_like_in_jakt = [](StringView source) -> ByteString {
ByteString replaced = AK::StringUtils::replace(source, "\\\""sv, "\""sv, ReplaceMode::All);
replaced = AK::StringUtils::replace(replaced.view(), "\\\\"sv, "\\"sv, ReplaceMode::All);
return replaced;
};
EXPECT_EQ(replace_like_in_jakt("\\\\\\\\\\\\\\\\"sv), "\\\\\\\\"sv);
EXPECT_EQ(replace_like_in_jakt(" auto str4 = \"\\\";"sv), " auto str4 = \"\";"sv);
EXPECT_EQ(replace_like_in_jakt(" auto str5 = \"\\\\\";"sv), " auto str5 = \"\\\";"sv);
}
TEST_CASE(to_snakecase)
{
EXPECT_EQ(AK::StringUtils::to_snakecase("foobar"sv), "foobar");