RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:28:12 +00:00
Code Issues Activity Actions

LibWeb: Use StyleComputer::invalidate_rule_cache() directly everywhere

Browse source 
Get rid of the old, roundabout way of invalidating the rule cache by
incrementing the StyleSheetList "generation".

Instead, when something wants to invalidate the rule cache, just have it
directly invalidate the rule cache. This makes it much easier to see
what's happening anyway.
This commit is contained in:
Andreas Kling 2022-03-14 20:31:57 +01:00
parent 72e6bff8b8
commit 759bfbb572
6 changed files with 6 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/CSS/CSSStyleSheet.cpp
View file

@ -42,7 +42,7 @@ DOM::ExceptionOr<unsigned> CSSStyleSheet::insert_rule(StringView rule, unsigned
if (!result.is_exception()) {
if (m_style_sheet_list) {
m_style_sheet_list->bump_generation();
m_style_sheet_list->document().style_computer().invalidate_rule_cache();
m_style_sheet_list->document().invalidate_style();
}
}
@ -61,7 +61,7 @@ DOM::ExceptionOr<void> CSSStyleSheet::delete_rule(unsigned index)
auto result = m_rules->remove_a_css_rule(index);
if (!result.is_exception()) {
if (m_style_sheet_list) {
m_style_sheet_list->bump_generation();
m_style_sheet_list->document().style_computer().invalidate_rule_cache();
m_style_sheet_list->document().invalidate_style();
}
}