RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 12:07:45 +00:00
Code Issues Activity Actions

LibWeb: Resolve two document-tree child browsing context count FIXMEs

Browse source 
This patch makes use of helpers implemented for window.length to resolve
two FIXMEs in WindowProxy previously simply assuming no child browsing
contexts :^)
This commit is contained in:
networkException 2022-09-06 19:56:44 +02:00 • committed by Linus Groh
parent e377e28fd2
commit 75ac47dbd8
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Userland/Libraries/LibWeb/Bindings/WindowProxy.cpp
View file

@ -72,8 +72,8 @@ JS::ThrowCompletionOr<Optional<JS::PropertyDescriptor>> WindowProxy::internal_ge
// 1. Let index be ! ToUint32(P). // 1. Let index be ! ToUint32(P).
auto index = property_key.as_number(); auto index = property_key.as_number();
// FIXME: 2. Let maxProperties be the number of document-tree child browsing contexts of W. // 2. Let maxProperties be the number of document-tree child browsing contexts of W.
size_t max_properties = 0; auto max_properties = TRY(m_window->document_tree_child_browsing_context_count());
// 3. Let value be undefined. // 3. Let value be undefined.
Optional<JS::Value> value; Optional<JS::Value> value;
@ -227,8 +227,8 @@ JS::ThrowCompletionOr<JS::MarkedVector<JS::Value>> WindowProxy::internal_own_pro
// 2. Let keys be a new empty List. // 2. Let keys be a new empty List.
auto keys = JS::MarkedVector<JS::Value> { vm.heap() }; auto keys = JS::MarkedVector<JS::Value> { vm.heap() };
// FIXME: 3. Let maxProperties be the number of document-tree child browsing contexts of W. // 3. Let maxProperties be the number of document-tree child browsing contexts of W.
size_t max_properties = 0; auto max_properties = TRY(m_window->document_tree_child_browsing_context_count());
// 4. Let index be 0. // 4. Let index be 0.
// 5. Repeat while index < maxProperties, // 5. Repeat while index < maxProperties,