RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 06:17:35 +00:00
Code Issues Activity Actions

LibJS: Convert Set.prototype to be a PrototypeObject

Browse source
This commit is contained in:
Timothy Flynn 2021-09-11 15:42:51 -04:00 • committed by Andreas Kling
parent a41d0d23f9
commit 75d5c17aec
2 changed files with 12 additions and 23 deletions
Download patch file Download diff file Expand all files Collapse all files

30
Userland/Libraries/LibJS/Runtime/SetPrototype.cpp
View file

@ -12,7 +12,7 @@
namespace JS { namespace JS {
SetPrototype::SetPrototype(GlobalObject& global_object) SetPrototype::SetPrototype(GlobalObject& global_object)
: Object(*global_object.object_prototype()) : PrototypeObject(*global_object.object_prototype())
{ {
} }
@ -44,22 +44,10 @@ SetPrototype::~SetPrototype()
{ {
} }
Set* SetPrototype::typed_this(VM& vm, GlobalObject& global_object)
{
auto* this_object = vm.this_value(global_object).to_object(global_object);
if (!this_object)
return {};
if (!is<Set>(this_object)) {
vm.throw_exception<TypeError>(global_object, ErrorType::NotAnObjectOfType, "Set");
return nullptr;
}
return static_cast<Set*>(this_object);
}
// 24.2.3.1 Set.prototype.add ( value ), https://tc39.es/ecma262/#sec-set.prototype.add // 24.2.3.1 Set.prototype.add ( value ), https://tc39.es/ecma262/#sec-set.prototype.add
JS_DEFINE_NATIVE_FUNCTION(SetPrototype::add) JS_DEFINE_NATIVE_FUNCTION(SetPrototype::add)
{ {
auto* set = typed_this(vm, global_object); auto* set = typed_this_object(global_object);
if (!set) if (!set)
return {}; return {};
auto value = vm.argument(0); auto value = vm.argument(0);
@ -72,7 +60,7 @@ JS_DEFINE_NATIVE_FUNCTION(SetPrototype::add)
// 24.2.3.2 Set.prototype.clear ( ), https://tc39.es/ecma262/#sec-set.prototype.clear // 24.2.3.2 Set.prototype.clear ( ), https://tc39.es/ecma262/#sec-set.prototype.clear
JS_DEFINE_NATIVE_FUNCTION(SetPrototype::clear) JS_DEFINE_NATIVE_FUNCTION(SetPrototype::clear)
{ {
auto* set = typed_this(vm, global_object); auto* set = typed_this_object(global_object);
if (!set) if (!set)
return {}; return {};
set->values().clear(); set->values().clear();
@ -82,7 +70,7 @@ JS_DEFINE_NATIVE_FUNCTION(SetPrototype::clear)
// 24.2.3.4 Set.prototype.delete ( value ), https://tc39.es/ecma262/#sec-set.prototype.delete // 24.2.3.4 Set.prototype.delete ( value ), https://tc39.es/ecma262/#sec-set.prototype.delete
JS_DEFINE_NATIVE_FUNCTION(SetPrototype::delete_) JS_DEFINE_NATIVE_FUNCTION(SetPrototype::delete_)
{ {
auto* set = typed_this(vm, global_object); auto* set = typed_this_object(global_object);
if (!set) if (!set)
return {}; return {};
return Value(set->values().remove(vm.argument(0))); return Value(set->values().remove(vm.argument(0)));
@ -91,7 +79,7 @@ JS_DEFINE_NATIVE_FUNCTION(SetPrototype::delete_)
// 24.2.3.5 Set.prototype.entries ( ), https://tc39.es/ecma262/#sec-set.prototype.entries // 24.2.3.5 Set.prototype.entries ( ), https://tc39.es/ecma262/#sec-set.prototype.entries
JS_DEFINE_NATIVE_FUNCTION(SetPrototype::entries) JS_DEFINE_NATIVE_FUNCTION(SetPrototype::entries)
{ {
auto* set = typed_this(vm, global_object); auto* set = typed_this_object(global_object);
if (!set) if (!set)
return {}; return {};
@ -101,7 +89,7 @@ JS_DEFINE_NATIVE_FUNCTION(SetPrototype::entries)
// 24.2.3.6 Set.prototype.forEach ( callbackfn [ , thisArg ] ), https://tc39.es/ecma262/#sec-set.prototype.foreach // 24.2.3.6 Set.prototype.forEach ( callbackfn [ , thisArg ] ), https://tc39.es/ecma262/#sec-set.prototype.foreach
JS_DEFINE_NATIVE_FUNCTION(SetPrototype::for_each) JS_DEFINE_NATIVE_FUNCTION(SetPrototype::for_each)
{ {
auto* set = typed_this(vm, global_object); auto* set = typed_this_object(global_object);
if (!set) if (!set)
return {}; return {};
if (!vm.argument(0).is_function()) { if (!vm.argument(0).is_function()) {
@ -120,7 +108,7 @@ JS_DEFINE_NATIVE_FUNCTION(SetPrototype::for_each)
// 24.2.3.7 Set.prototype.has ( value ), https://tc39.es/ecma262/#sec-set.prototype.has // 24.2.3.7 Set.prototype.has ( value ), https://tc39.es/ecma262/#sec-set.prototype.has
JS_DEFINE_NATIVE_FUNCTION(SetPrototype::has) JS_DEFINE_NATIVE_FUNCTION(SetPrototype::has)
{ {
auto* set = typed_this(vm, global_object); auto* set = typed_this_object(global_object);
if (!set) if (!set)
return {}; return {};
auto& values = set->values(); auto& values = set->values();
@ -130,7 +118,7 @@ JS_DEFINE_NATIVE_FUNCTION(SetPrototype::has)
// 24.2.3.10 Set.prototype.values ( ), https://tc39.es/ecma262/#sec-set.prototype.values // 24.2.3.10 Set.prototype.values ( ), https://tc39.es/ecma262/#sec-set.prototype.values
JS_DEFINE_NATIVE_FUNCTION(SetPrototype::values) JS_DEFINE_NATIVE_FUNCTION(SetPrototype::values)
{ {
auto* set = typed_this(vm, global_object); auto* set = typed_this_object(global_object);
if (!set) if (!set)
return {}; return {};
@ -140,7 +128,7 @@ JS_DEFINE_NATIVE_FUNCTION(SetPrototype::values)
// 24.2.3.9 get Set.prototype.size, https://tc39.es/ecma262/#sec-get-set.prototype.size // 24.2.3.9 get Set.prototype.size, https://tc39.es/ecma262/#sec-get-set.prototype.size
JS_DEFINE_NATIVE_GETTER(SetPrototype::size_getter) JS_DEFINE_NATIVE_GETTER(SetPrototype::size_getter)
{ {
auto* set = typed_this(vm, global_object); auto* set = typed_this_object(global_object);
if (!set) if (!set)
return {}; return {};
return Value(set->values().size()); return Value(set->values().size());

5
Userland/Libraries/LibJS/Runtime/SetPrototype.h
View file

@ -6,12 +6,13 @@
#pragma once #pragma once
#include <LibJS/Runtime/PrototypeObject.h>
#include <LibJS/Runtime/Set.h> #include <LibJS/Runtime/Set.h>
namespace JS { namespace JS {
class SetPrototype final : public Object { class SetPrototype final : public PrototypeObject<SetPrototype, Set> {
JS_OBJECT(SetPrototype, Object); JS_PROTOTYPE_OBJECT(SetPrototype, Set, Set);
public: public:
SetPrototype(GlobalObject&); SetPrototype(GlobalObject&);