RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 17:37:37 +00:00
Code Issues Activity Actions

LibWeb: Make CSS ParsingContext::m_url not Optional

Browse source 
This always has a value, so let's make that clearer.
This commit is contained in:
Sam Atkins 2022-04-25 16:17:21 +01:00 • committed by Andreas Kling
parent 25970f2763
commit 761d29d647
2 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
Userland/Libraries/LibWeb/CSS/Parser/Parser.cpp
View file

@ -36,7 +36,7 @@ static void log_parse_error(SourceLocation const& location = SourceLocation::cur
namespace Web::CSS::Parser { namespace Web::CSS::Parser {
ParsingContext::ParsingContext(DOM::Document const& document, Optional<AK::URL> const url) ParsingContext::ParsingContext(DOM::Document const& document, AK::URL url)
: m_document(&document) : m_document(&document)
, m_url(move(url)) , m_url(move(url))
{ {
@ -62,7 +62,7 @@ bool ParsingContext::in_quirks_mode() const
// https://www.w3.org/TR/css-values-4/#relative-urls // https://www.w3.org/TR/css-values-4/#relative-urls
AK::URL ParsingContext::complete_url(String const& addr) const AK::URL ParsingContext::complete_url(String const& addr) const
{ {
return m_url.has_value() ? m_url->complete_url(addr) : AK::URL::create_with_url_or_path(addr); return m_url.complete_url(addr);
} }
template<typename T> template<typename T>

4
Userland/Libraries/LibWeb/CSS/Parser/Parser.h
View file

@ -36,7 +36,7 @@ class ParsingContext {
public: public:
ParsingContext() = default; ParsingContext() = default;
explicit ParsingContext(DOM::Document const&); explicit ParsingContext(DOM::Document const&);
explicit ParsingContext(DOM::Document const&, Optional<AK::URL> const); explicit ParsingContext(DOM::Document const&, AK::URL);
explicit ParsingContext(DOM::ParentNode&); explicit ParsingContext(DOM::ParentNode&);
bool in_quirks_mode() const; bool in_quirks_mode() const;
@ -49,7 +49,7 @@ public:
private: private:
DOM::Document const* m_document { nullptr }; DOM::Document const* m_document { nullptr };
PropertyID m_current_property_id { PropertyID::Invalid }; PropertyID m_current_property_id { PropertyID::Invalid };
Optional<AK::URL> m_url; AK::URL m_url;
}; };
template<typename T> template<typename T>