mirror of
https://github.com/RGBCube/serenity
synced 2025-07-25 03:47:35 +00:00
Everywhere: Switch from (void) to [[maybe_unused]] (#4473)
Problem: - `(void)` simply casts the expression to void. This is understood to indicate that it is ignored, but this is really a compiler trick to get the compiler to not generate a warning. Solution: - Use the `[[maybe_unused]]` attribute to indicate the value is unused. Note: - Functions taking a `(void)` argument list have also been changed to `()` because this is not needed and shows up in the same grep command.
This commit is contained in:
parent
4421d98e30
commit
765936ebae
103 changed files with 219 additions and 362 deletions
|
@ -138,8 +138,7 @@ bool Utf8View::validate(size_t& valid_bytes) const
|
|||
size_t Utf8View::calculate_length() const
|
||||
{
|
||||
size_t length = 0;
|
||||
for (auto code_point : *this) {
|
||||
(void)code_point;
|
||||
for ([[maybe_unused]] auto code_point : *this) {
|
||||
++length;
|
||||
}
|
||||
return length;
|
||||
|
@ -170,7 +169,6 @@ Utf8CodepointIterator& Utf8CodepointIterator::operator++()
|
|||
bool first_byte_makes_sense = decode_first_byte(*m_ptr, code_point_length_in_bytes, value);
|
||||
|
||||
ASSERT(first_byte_makes_sense);
|
||||
(void)value;
|
||||
|
||||
ASSERT(code_point_length_in_bytes <= m_length);
|
||||
m_ptr += code_point_length_in_bytes;
|
||||
|
|
Loading…
Add table
Add a link
Reference in a new issue