RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 07:47:37 +00:00
Code Issues Activity Actions

Everywhere: Switch from (void) to [[maybe_unused]] (#4473)

Browse source 
Problem:
- `(void)` simply casts the expression to void. This is understood to
  indicate that it is ignored, but this is really a compiler trick to
  get the compiler to not generate a warning.

Solution:
- Use the `[[maybe_unused]]` attribute to indicate the value is unused.

Note:
- Functions taking a `(void)` argument list have also been changed to
  `()` because this is not needed and shows up in the same grep
  command.
This commit is contained in:
Lenny Maiorani 2020-12-20 16:09:48 -07:00 • committed by GitHub
parent 4421d98e30
commit 765936ebae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
103 changed files with 219 additions and 362 deletions
Download patch file Download diff file Expand all files Collapse all files

6
DevTools/HackStudio/TerminalWrapper.cpp
View file

@ -107,13 +107,13 @@ void TerminalWrapper::run_command(const String& command)
tcsetpgrp(pts_fd, getpid());
// NOTE: It's okay if this fails.
(void)ioctl(0, TIOCNOTTY);
int rc = ioctl(0, TIOCNOTTY);
close(0);
close(1);
close(2);
int rc = dup2(pts_fd, 0);
rc = dup2(pts_fd, 0);
if (rc < 0) {
perror("dup2");
exit(1);
@ -164,7 +164,7 @@ void TerminalWrapper::kill_running_command()
ASSERT(m_pid != -1);
// Kill our child process and its whole process group.
(void)killpg(m_pid, SIGTERM);
[[maybe_unused]] auto rc = killpg(m_pid, SIGTERM);
}
TerminalWrapper::TerminalWrapper(bool user_spawned)

12
DevTools/HackStudio/WidgetTool.cpp
View file

@ -29,27 +29,23 @@
namespace HackStudio {
void WidgetTool::on_mousedown(GUI::MouseEvent& event)
void WidgetTool::on_mousedown([[maybe_unused]] GUI::MouseEvent& event)
{
(void)event;
dbgln("WidgetTool::on_mousedown");
}
void WidgetTool::on_mouseup(GUI::MouseEvent& event)
void WidgetTool::on_mouseup([[maybe_unused]] GUI::MouseEvent& event)
{
(void)event;
dbgln("WidgetTool::on_mouseup");
}
void WidgetTool::on_mousemove(GUI::MouseEvent& event)
void WidgetTool::on_mousemove([[maybe_unused]] GUI::MouseEvent& event)
{
(void)event;
dbgln("WidgetTool::on_mousemove");
}
void WidgetTool::on_keydown(GUI::KeyEvent& event)
void WidgetTool::on_keydown([[maybe_unused]] GUI::KeyEvent& event)
{
(void)event;
dbgln("WidgetTool::on_keydown");
}