RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 14:48:14 +00:00
Code Issues Activity Actions

Everywhere: Switch from (void) to [[maybe_unused]] (#4473)

Browse source 
Problem:
- `(void)` simply casts the expression to void. This is understood to
  indicate that it is ignored, but this is really a compiler trick to
  get the compiler to not generate a warning.

Solution:
- Use the `[[maybe_unused]]` attribute to indicate the value is unused.

Note:
- Functions taking a `(void)` argument list have also been changed to
  `()` because this is not needed and shows up in the same grep
  command.
This commit is contained in:
Lenny Maiorani 2020-12-20 16:09:48 -07:00 • committed by GitHub
parent 4421d98e30
commit 765936ebae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
103 changed files with 219 additions and 362 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Kernel/CoreDump.cpp
View file

@ -116,7 +116,7 @@ void CoreDump::write_elf_header()
elf_file_header.e_shnum = 0;
elf_file_header.e_shstrndx = SHN_UNDEF;
(void)m_fd->write(UserOrKernelBuffer::for_kernel_buffer(reinterpret_cast<uint8_t*>(&elf_file_header)), sizeof(Elf32_Ehdr));
[[maybe_unused]] auto rc = m_fd->write(UserOrKernelBuffer::for_kernel_buffer(reinterpret_cast<uint8_t*>(&elf_file_header)), sizeof(Elf32_Ehdr));
}
void CoreDump::write_program_headers(size_t notes_size)
@ -142,7 +142,7 @@ void CoreDump::write_program_headers(size_t notes_size)
offset += phdr.p_filesz;
(void)m_fd->write(UserOrKernelBuffer::for_kernel_buffer(reinterpret_cast<uint8_t*>(&phdr)), sizeof(Elf32_Phdr));
[[maybe_unused]] auto rc = m_fd->write(UserOrKernelBuffer::for_kernel_buffer(reinterpret_cast<uint8_t*>(&phdr)), sizeof(Elf32_Phdr));
}
Elf32_Phdr notes_pheader {};
@ -155,7 +155,7 @@ void CoreDump::write_program_headers(size_t notes_size)
notes_pheader.p_align = 0;
notes_pheader.p_flags = 0;
(void)m_fd->write(UserOrKernelBuffer::for_kernel_buffer(reinterpret_cast<uint8_t*>(&notes_pheader)), sizeof(Elf32_Phdr));
[[maybe_unused]] auto rc = m_fd->write(UserOrKernelBuffer::for_kernel_buffer(reinterpret_cast<uint8_t*>(&notes_pheader)), sizeof(Elf32_Phdr));
}
void CoreDump::write_regions()
@ -182,14 +182,14 @@ void CoreDump::write_regions()
// (A page may not be backed by a physical page because it has never been faulted in when the process ran).
src_buffer = UserOrKernelBuffer::for_kernel_buffer(zero_buffer);
}
(void)m_fd->write(src_buffer.value(), PAGE_SIZE);
[[maybe_unused]] auto rc = m_fd->write(src_buffer.value(), PAGE_SIZE);
}
}
}
void CoreDump::write_notes_segment(ByteBuffer& notes_segment)
{
(void)m_fd->write(UserOrKernelBuffer::for_kernel_buffer(notes_segment.data()), notes_segment.size());
[[maybe_unused]] auto rc = m_fd->write(UserOrKernelBuffer::for_kernel_buffer(notes_segment.data()), notes_segment.size());
}
ByteBuffer CoreDump::create_notes_threads_data() const
@ -264,7 +264,7 @@ void CoreDump::write()
write_regions();
write_notes_segment(notes_segment);
(void)m_fd->chmod(0400); // Make coredump file readable
[[maybe_unused]] auto rc = m_fd->chmod(0400); // Make coredump file readable
}
}