1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-05-31 05:38:11 +00:00

Everywhere: Switch from (void) to [[maybe_unused]] (#4473)

Problem:
- `(void)` simply casts the expression to void. This is understood to
  indicate that it is ignored, but this is really a compiler trick to
  get the compiler to not generate a warning.

Solution:
- Use the `[[maybe_unused]]` attribute to indicate the value is unused.

Note:
- Functions taking a `(void)` argument list have also been changed to
  `()` because this is not needed and shows up in the same grep
  command.
This commit is contained in:
Lenny Maiorani 2020-12-20 16:09:48 -07:00 committed by GitHub
parent 4421d98e30
commit 765936ebae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
103 changed files with 219 additions and 362 deletions

View file

@ -213,7 +213,7 @@ void Thread::die_if_needed()
return;
u32 unlock_count;
(void)unlock_process_if_locked(unlock_count);
[[maybe_unused]] auto rc = unlock_process_if_locked(unlock_count);
ScopedCritical critical;
set_should_die();
@ -240,7 +240,7 @@ void Thread::exit(void* exit_value)
m_join_condition.thread_did_exit(exit_value);
set_should_die();
u32 unlock_count;
(void)unlock_process_if_locked(unlock_count);
[[maybe_unused]] auto rc = unlock_process_if_locked(unlock_count);
die_if_needed();
}