1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 04:17:35 +00:00

Everywhere: Switch from (void) to [[maybe_unused]] (#4473)

Problem:
- `(void)` simply casts the expression to void. This is understood to
  indicate that it is ignored, but this is really a compiler trick to
  get the compiler to not generate a warning.

Solution:
- Use the `[[maybe_unused]]` attribute to indicate the value is unused.

Note:
- Functions taking a `(void)` argument list have also been changed to
  `()` because this is not needed and shows up in the same grep
  command.
This commit is contained in:
Lenny Maiorani 2020-12-20 16:09:48 -07:00 committed by GitHub
parent 4421d98e30
commit 765936ebae
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
103 changed files with 219 additions and 362 deletions

View file

@ -39,10 +39,8 @@ char PC;
char* UP;
char* BC;
int tgetent(char* bp, const char* name)
int tgetent([[maybe_unused]] char* bp, [[maybe_unused]] const char* name)
{
(void)bp;
(void)name;
#ifdef TERMCAP_DEBUG
fprintf(stderr, "tgetent: bp=%p, name='%s'\n", bp, name);
#endif
@ -120,9 +118,8 @@ char* tgetstr(const char* id, char** area)
#pragma GCC diagnostic pop
int tgetflag(const char* id)
int tgetflag([[maybe_unused]] const char* id)
{
(void)id;
#ifdef TERMCAP_DEBUG
fprintf(stderr, "tgetflag: '%s'\n", id);
#endif
@ -143,17 +140,13 @@ int tgetnum(const char* id)
ASSERT_NOT_REACHED();
}
char* tgoto(const char* cap, int col, int row)
char* tgoto([[maybe_unused]] const char* cap, [[maybe_unused]] int col, [[maybe_unused]] int row)
{
(void)cap;
(void)col;
(void)row;
ASSERT_NOT_REACHED();
}
int tputs(const char* str, int affcnt, int (*putc)(int))
int tputs(const char* str, [[maybe_unused]] int affcnt, int (*putc)(int))
{
(void)affcnt;
size_t len = strlen(str);
for (size_t i = 0; i < len; ++i)
putc(str[i]);