RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 20:47:45 +00:00
Code Issues Activity Actions

LibWeb: Remove old Layout::Node::split_into_lines() API

Browse source 
Now that we build lines incrementally, we no longer need the atomic line
splitting API.

The new InlineLevelIterator and LineBuilder setup does have some
regressions from the old behavior, but we can deal with them as we go.
This commit is contained in:
Andreas Kling 2022-01-21 13:34:29 +01:00
parent ba49dc82e0
commit 766d816db3
12 changed files with 0 additions and 167 deletions
Download patch file Download diff file Expand all files Collapse all files

17
Userland/Libraries/LibWeb/Layout/BlockContainer.cpp
View file

@ -104,23 +104,6 @@ HitTestResult BlockContainer::hit_test(const Gfx::IntPoint& position, HitTestTyp
return { absolute_rect().contains(position.x(), position.y()) ? this : nullptr };
}
void BlockContainer::split_into_lines(InlineFormattingContext& context, LayoutMode layout_mode)
{
auto& containing_block = context.containing_block();
auto* line_box = &containing_block.ensure_last_line_box();
context.dimension_box_on_line(*this, layout_mode);
float available_width = context.available_width_at_line(containing_block.line_boxes().size() - 1);
if (layout_mode == LayoutMode::AllPossibleLineBreaks && line_box->width() > 0) {
line_box = &containing_block.add_line_box();
} else if (layout_mode == LayoutMode::Default && line_box->width() > 0 && line_box->width() + border_box_width() > available_width) {
line_box = &containing_block.add_line_box();
}
line_box->add_fragment(*this, 0, 0, border_box_width(), height());
}
bool BlockContainer::is_scrollable() const
{
// FIXME: Support horizontal scroll as well (overflow-x)