RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 22:27:44 +00:00
Code Issues Activity Actions

LibJS: Remove MarkedValueList in favor of MarkedVector<Value> :^)

Browse source
This commit is contained in:
Linus Groh 2022-02-09 10:18:48 +00:00
parent 6508ff5bbd
commit 7676b1b925
6 changed files with 0 additions and 116 deletions
Download patch file Download diff file Expand all files Collapse all files

19
Userland/Libraries/LibJS/Heap/Heap.cpp
View file

@ -113,13 +113,6 @@ void Heap::gather_roots(HashTable<Cell*>& roots)
for (auto& handle : m_handles)
roots.set(handle.cell());
for (auto& list : m_marked_value_lists) {
for (auto& value : list.values()) {
if (value.is_cell())
roots.set(&value.as_cell());
}
}
for (auto& vector : m_marked_vectors)
vector.gather_roots(roots);
@ -293,18 +286,6 @@ void Heap::did_destroy_handle(Badge<HandleImpl>, HandleImpl& impl)
m_handles.remove(impl);
}
void Heap::did_create_marked_value_list(Badge<MarkedValueList>, MarkedValueList& list)
{
VERIFY(!m_marked_value_lists.contains(list));
m_marked_value_lists.append(list);
}
void Heap::did_destroy_marked_value_list(Badge<MarkedValueList>, MarkedValueList& list)
{
VERIFY(m_marked_value_lists.contains(list));
m_marked_value_lists.remove(list);
}
void Heap::did_create_marked_vector(Badge<MarkedVectorBase>, MarkedVectorBase& vector)
{
VERIFY(!m_marked_vectors.contains(vector));

7
Userland/Libraries/LibJS/Heap/Heap.h
View file

@ -20,7 +20,6 @@
#include <LibJS/Heap/CellAllocator.h>
#include <LibJS/Heap/Handle.h>
#include <LibJS/Heap/MarkedVector.h>
#include <LibJS/Runtime/MarkedValueList.h>
#include <LibJS/Runtime/Object.h>
#include <LibJS/Runtime/WeakContainer.h>
@ -67,9 +66,6 @@ public:
void did_create_handle(Badge<HandleImpl>, HandleImpl&);
void did_destroy_handle(Badge<HandleImpl>, HandleImpl&);
void did_create_marked_value_list(Badge<MarkedValueList>, MarkedValueList&);
void did_destroy_marked_value_list(Badge<MarkedValueList>, MarkedValueList&);
void did_create_marked_vector(Badge<MarkedVectorBase>, MarkedVectorBase&);
void did_destroy_marked_vector(Badge<MarkedVectorBase>, MarkedVectorBase&);
@ -112,10 +108,7 @@ private:
Vector<NonnullOwnPtr<CellAllocator>> m_allocators;
HandleImpl::List m_handles;
MarkedVectorBase::List m_marked_vectors;
MarkedValueList::List m_marked_value_lists;
WeakContainer::List m_weak_containers;
Vector<Cell*> m_uprooted_cells;