RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 11:37:34 +00:00
Code Issues Activity Actions

LibWeb: Make sure collapsed margins are not ignored if box creates FC

Browse source 
Fixes a bug that if box creates new formatting context then all already
collapsed margins are ignored and only margin_top is used.
This commit is contained in:
Aliaksandr Kalenik 2023-05-22 13:03:00 +03:00 • committed by Andreas Kling
parent 668578ddc0
commit 76aa17be86
3 changed files with 30 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

6
Tests/LibWeb/Layout/expected/block-and-inline/margin-collapse-6.txt Normal file
View file

@ -0,0 +1,6 @@
Viewport <#document> at (0,0) content-size 800x600 children: not-inline
BlockContainer <html> at (0,0) content-size 800x106 [BFC] children: not-inline
BlockContainer <body> at (8,8) content-size 784x90 children: not-inline
BlockContainer <div.upper> at (8,8) content-size 784x20 children: not-inline
BlockContainer <div.bfc> at (8,78) content-size 784x20 [BFC] children: not-inline
BlockContainer <div.inner> at (8,78) content-size 20x20 children: not-inline

15
Tests/LibWeb/Layout/input/block-and-inline/margin-collapse-6.html Normal file
View file

@ -0,0 +1,15 @@
<!doctype html><style>
.upper {
margin-bottom: 50px;
height: 20px;
background: lime;
}
.bfc {
display: flow-root;
}
.inner {
width: 20px;
height: 20px;
background: black;
}
</style><div class="upper"></div><div class=bfc><div class="inner">