RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-24 21:37:34 +00:00
Code Issues Activity Actions

LibCore: Make usernames optional in ProcessStatisticsReader

Browse source
This commit is contained in:
Peter Elliott 2022-10-02 18:17:24 -06:00 • committed by Andreas Kling
parent 71728f3ea6
commit 76c67b7ae9
2 changed files with 8 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

10
Userland/Libraries/LibCore/ProcessStatisticsReader.cpp
View file

@ -16,7 +16,7 @@ namespace Core {
HashMap<uid_t, String> ProcessStatisticsReader::s_usernames; HashMap<uid_t, String> ProcessStatisticsReader::s_usernames;
Optional<AllProcessesStatistics> ProcessStatisticsReader::get_all(RefPtr<Core::File>& proc_all_file) Optional<AllProcessesStatistics> ProcessStatisticsReader::get_all(RefPtr<Core::File>& proc_all_file, bool include_usernames)
{ {
if (proc_all_file) { if (proc_all_file) {
if (!proc_all_file->seek(0, Core::SeekMode::SetPosition)) { if (!proc_all_file->seek(0, Core::SeekMode::SetPosition)) {
@ -93,7 +93,9 @@ Optional<AllProcessesStatistics> ProcessStatisticsReader::get_all(RefPtr<Core::F
}); });
// and synthetic data last // and synthetic data last
process.username = username_from_uid(process.uid); if (include_usernames) {
process.username = username_from_uid(process.uid);
}
all_processes_statistics.processes.append(move(process)); all_processes_statistics.processes.append(move(process));
}); });
@ -102,10 +104,10 @@ Optional<AllProcessesStatistics> ProcessStatisticsReader::get_all(RefPtr<Core::F
return all_processes_statistics; return all_processes_statistics;
} }
Optional<AllProcessesStatistics> ProcessStatisticsReader::get_all() Optional<AllProcessesStatistics> ProcessStatisticsReader::get_all(bool include_usernames)
{ {
RefPtr<Core::File> proc_all_file; RefPtr<Core::File> proc_all_file;
return get_all(proc_all_file); return get_all(proc_all_file, include_usernames);
} }
String ProcessStatisticsReader::username_from_uid(uid_t uid) String ProcessStatisticsReader::username_from_uid(uid_t uid)

4
Userland/Libraries/LibCore/ProcessStatisticsReader.h
View file

@ -72,8 +72,8 @@ struct AllProcessesStatistics {
class ProcessStatisticsReader { class ProcessStatisticsReader {
public: public:
static Optional<AllProcessesStatistics> get_all(RefPtr<Core::File>&); static Optional<AllProcessesStatistics> get_all(RefPtr<Core::File>&, bool include_usernames = true);
static Optional<AllProcessesStatistics> get_all(); static Optional<AllProcessesStatistics> get_all(bool include_usernames = true);
private: private:
static String username_from_uid(uid_t); static String username_from_uid(uid_t);