From 76deda802d8b40f39e4818ba26b9a27f9304df18 Mon Sep 17 00:00:00 2001 From: Gunnar Beutner Date: Wed, 12 May 2021 17:24:50 +0200 Subject: [PATCH] Kernel: Avoid allocating and then freeing packet buffers We already have another limit for the total number of packet buffers allowed (max_packet_buffers). This second limit caused us to repeatedly allocate and then free buffers. --- Kernel/Net/NetworkAdapter.cpp | 6 ++---- 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/Kernel/Net/NetworkAdapter.cpp b/Kernel/Net/NetworkAdapter.cpp index 4b5bc33f24..379a740cc8 100644 --- a/Kernel/Net/NetworkAdapter.cpp +++ b/Kernel/Net/NetworkAdapter.cpp @@ -199,10 +199,8 @@ size_t NetworkAdapter::dequeue_packet(u8* buffer, size_t buffer_size, Time& pack size_t packet_size = packet.size(); VERIFY(packet_size <= buffer_size); memcpy(buffer, packet.data(), packet_size); - if (m_unused_packet_buffers_count < 100) { - m_unused_packet_buffers.append(packet); - ++m_unused_packet_buffers_count; - } + m_unused_packet_buffers.append(packet); + ++m_unused_packet_buffers_count; return packet_size; }