RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 18:17:44 +00:00
Code Issues Activity Actions

Ladybird: Fix context menus being in slightly the wrong position

Browse source 
Previously, we were doing mapToGlobal() via the Tab widget, but the
widget position was actually relative to the WebContentView. This
meant context menus appeared slightly vertically offset from where
you clicked.
This commit is contained in:
MacDue 2023-05-16 20:30:43 +01:00 • committed by Tim Flynn
parent b0edc7b6e4
commit 77008d4bac
1 changed files with 4 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

8
Ladybird/Tab.cpp
View file

@ -221,7 +221,7 @@ Tab::Tab(BrowserWindow* window, StringView webdriver_content_ipc_path, WebView::
m_page_context_menu->addAction(&m_window->inspect_dom_node_action());
view().on_context_menu_request = [this](auto widget_position) {
auto screen_position = mapToGlobal(QPoint { widget_position.x(), widget_position.y() });
auto screen_position = view().mapToGlobal(QPoint { widget_position.x(), widget_position.y() });
m_page_context_menu->exec(screen_position);
};
@ -254,7 +254,7 @@ Tab::Tab(BrowserWindow* window, StringView webdriver_content_ipc_path, WebView::
view().on_link_context_menu_request = [this](auto const& url, auto widget_position) {
m_link_context_menu_url = url;
auto screen_position = mapToGlobal(QPoint { widget_position.x(), widget_position.y() });
auto screen_position = view().mapToGlobal(QPoint { widget_position.x(), widget_position.y() });
m_link_context_menu->exec(screen_position);
};
@ -308,7 +308,7 @@ Tab::Tab(BrowserWindow* window, StringView webdriver_content_ipc_path, WebView::
m_image_context_menu_url = image_url;
m_image_context_menu_bitmap = shareable_bitmap;
auto screen_position = mapToGlobal(QPoint { widget_position.x(), widget_position.y() });
auto screen_position = view().mapToGlobal(QPoint { widget_position.x(), widget_position.y() });
m_image_context_menu->exec(screen_position);
};
@ -377,7 +377,7 @@ Tab::Tab(BrowserWindow* window, StringView webdriver_content_ipc_path, WebView::
m_video_context_menu_controls_action->setChecked(has_user_agent_controls);
m_video_context_menu_loop_action->setChecked(is_looping);
auto screen_position = mapToGlobal(QPoint { widget_position.x(), widget_position.y() });
auto screen_position = view().mapToGlobal(QPoint { widget_position.x(), widget_position.y() });
m_video_context_menu->exec(screen_position);
};
}