From 781e3aea8b3c8f7e39a42fba45b519d3a5db644c Mon Sep 17 00:00:00 2001 From: Timothy Flynn Date: Wed, 14 Dec 2022 09:59:54 -0500 Subject: [PATCH] LibSQL: Convert string values to a double in a locale-independent manner This currently uses strtod, which is locale-dependent. Use the locale- independent method added in 65ee9b4134225398f0a5109eb79b0baba98c9cd6. --- Userland/Libraries/LibSQL/Value.cpp | 9 +-------- 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/Userland/Libraries/LibSQL/Value.cpp b/Userland/Libraries/LibSQL/Value.cpp index 86f2ecf94e..884d465cbe 100644 --- a/Userland/Libraries/LibSQL/Value.cpp +++ b/Userland/Libraries/LibSQL/Value.cpp @@ -231,14 +231,7 @@ Optional Value::to_double() const return {}; return m_value->visit( - [](DeprecatedString const& value) -> Optional { - char* end = nullptr; - double result = strtod(value.characters(), &end); - - if (end == value.characters()) - return {}; - return result; - }, + [](DeprecatedString const& value) -> Optional { return value.to_double(); }, [](Integer auto value) -> Optional { return static_cast(value); }, [](double value) -> Optional { return value; }, [](bool value) -> Optional { return static_cast(value); },