RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 16:17:45 +00:00
Code Issues Activity Actions

LibGfx: Fix clipping in fill_ellipse

Browse source 
fill_ellipse used to clip the bounding box, so instead of drawing a
part of an ellipse it drew a smaller ellipse. This commit fixes this
behaviour.
This commit is contained in:
Egor Ananyin 2021-05-08 20:15:03 +03:00 • committed by Linus Groh
parent 5eb062d8d3
commit 782dc348fd
1 changed files with 4 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibGfx/Painter.cpp
View file

@ -255,14 +255,10 @@ void Painter::fill_ellipse(const IntRect& a_rect, Color color)
VERIFY(m_target->rect().contains(rect));
RGBA32* dst = m_target->scanline(rect.top()) + rect.left() + rect.width() / 2;
const size_t dst_skip = m_target->pitch() / sizeof(RGBA32);
for (int i = 0; i < rect.height(); i++) {
double y = rect.height() * 0.5 - i;
double x = rect.width() * sqrt(0.25 - y * y / rect.height() / rect.height());
fast_u32_fill(dst - (int)x, color.value(), 2 * (int)x);
dst += dst_skip;
for (int i = 1; i < a_rect.height(); i++) {
double y = a_rect.height() * 0.5 - i;
double x = a_rect.width() * sqrt(0.25 - y * y / a_rect.height() / a_rect.height());
draw_line({ a_rect.x() + a_rect.width() / 2 - (int)x, a_rect.y() + i }, { a_rect.x() + a_rect.width() / 2 + (int)x - 1, a_rect.y() + i }, color);
}
}