RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-27 07:47:35 +00:00
Code Issues Activity Actions

Everywhere: Explicitly link all binaries against the LibC target

Browse source 
Even though the toolchain implicitly links against -lc, it does not know
where it should get LibC from except for the sysroot. In the case of
Clang this causes it to pick up the LibC stub instead, which might be
slightly outdated and feature missing symbols.

This is currently not an issue that manifests because we pass through
the dependency on LibC and other libraries by accident, which causes
CMake to link against the LibC target (instead of just the library),
and thus points the linker at the build output directory.

Since we are looking to fix that in the upcoming commits, let's make
sure that everything will still be able to find the proper LibC first.
This commit is contained in:
Tim Schumacher 2022-10-22 15:13:49 +02:00 • committed by Linus Groh
parent 39fca21e11
commit 7834e26ddb
39 changed files with 42 additions and 33 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibCodeComprehension/Shell/CMakeLists.txt
View file

@ -3,4 +3,4 @@ set(SOURCES
)
serenity_lib(LibShellComprehension shellcomprehension)
target_link_libraries(LibShellComprehension LibCodeComprehension LibC)
target_link_libraries(LibShellComprehension LibCodeComprehension)