From 78419e858de19c48505c0da20272f782edbc9864 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?S=C3=B6nke=20Holz?= <sholz8530@gmail.com>
Date: Sun, 10 Dec 2023 18:25:54 +0100
Subject: [PATCH] Kernel/Graphics: Don't use `[[gnu::packed]]` on Bochs VGA
 structs

The `[[gnu::packed]]` attribute apparently lowered the required
alignment of the structs, which caused the compiler to generate two
1 byte loads/stores on RISC-V. This caused the kernel to read/write
incorrect values, as the device only seems to accept 2 byte operations.
---
 Kernel/Devices/GPU/Bochs/Definitions.h | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/Kernel/Devices/GPU/Bochs/Definitions.h b/Kernel/Devices/GPU/Bochs/Definitions.h
index 1891b9f756..fb41d31cb6 100644
--- a/Kernel/Devices/GPU/Bochs/Definitions.h
+++ b/Kernel/Devices/GPU/Bochs/Definitions.h
@@ -37,7 +37,7 @@ enum class BochsDISPIRegisters {
     VIDEO_RAM_64K_CHUNKS_COUNT = 0xA,
 };
 
-struct [[gnu::packed]] DISPIInterface {
+struct DISPIInterface {
     u16 index_id;
     u16 xres;
     u16 yres;
@@ -50,13 +50,15 @@ struct [[gnu::packed]] DISPIInterface {
     u16 y_offset;
     u16 vram_64k_chunks_count;
 };
+static_assert(AssertSize<DISPIInterface, 22>());
 
-struct [[gnu::packed]] ExtensionRegisters {
+struct ExtensionRegisters {
     u32 region_size;
     u32 framebuffer_byteorder;
 };
+static_assert(AssertSize<ExtensionRegisters, 8>());
 
-struct [[gnu::packed]] BochsDisplayMMIORegisters {
+struct BochsDisplayMMIORegisters {
     u8 edid_data[0x400];
     u16 vga_ioports[0x10];
     u8 reserved[0xE0];
@@ -64,5 +66,6 @@ struct [[gnu::packed]] BochsDisplayMMIORegisters {
     u8 reserved2[0x100 - sizeof(DISPIInterface)];
     ExtensionRegisters extension_regs;
 };
+static_assert(AssertSize<BochsDisplayMMIORegisters, 1544>());
 
 }