RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-25 18:57:45 +00:00
Code Issues Activity Actions

LibJS: Don't use null DFS for break/continue statements without a label

Browse source
This commit is contained in:
Dan Klishch 2024-01-24 13:32:02 -05:00 • committed by Andrew Kaster
parent 761d16141d
commit 78491204d9
3 changed files with 17 additions and 17 deletions
Download patch file Download diff file Expand all files Collapse all files

12
Userland/Libraries/LibJS/AST.h
View file

@ -2118,22 +2118,22 @@ private:
class BreakStatement final : public Statement {
public:
BreakStatement(SourceRange source_range, DeprecatedFlyString target_label)
BreakStatement(SourceRange source_range, Optional<DeprecatedFlyString> target_label)
: Statement(move(source_range))
, m_target_label(move(target_label))
{
}
DeprecatedFlyString const& target_label() const { return m_target_label; }
Optional<DeprecatedFlyString> const& target_label() const { return m_target_label; }
virtual Bytecode::CodeGenerationErrorOr<Optional<Bytecode::Operand>> generate_bytecode(Bytecode::Generator&, Optional<Bytecode::Operand> preferred_dst = {}) const override;
private:
DeprecatedFlyString m_target_label;
Optional<DeprecatedFlyString> m_target_label;
};
class ContinueStatement final : public Statement {
public:
ContinueStatement(SourceRange source_range, DeprecatedFlyString target_label)
ContinueStatement(SourceRange source_range, Optional<DeprecatedFlyString> target_label)
: Statement(move(source_range))
, m_target_label(move(target_label))
{
@ -2141,10 +2141,10 @@ public:
virtual Bytecode::CodeGenerationErrorOr<Optional<Bytecode::Operand>> generate_bytecode(Bytecode::Generator&, Optional<Bytecode::Operand> preferred_dst = {}) const override;
DeprecatedFlyString const& target_label() const { return m_target_label; }
Optional<DeprecatedFlyString> const& target_label() const { return m_target_label; }
private:
DeprecatedFlyString m_target_label;
Optional<DeprecatedFlyString> m_target_label;
};
class DebuggerStatement final : public Statement {