From 7852915dd3737a51a99120c2b98902782889a413 Mon Sep 17 00:00:00 2001 From: Kenneth Myhra Date: Tue, 14 Feb 2023 22:57:59 +0100 Subject: [PATCH] LibWeb: Make factory method of DOM::MutationObserver fallible --- Userland/Libraries/LibWeb/DOM/MutationObserver.cpp | 4 ++-- Userland/Libraries/LibWeb/DOM/MutationObserver.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/Userland/Libraries/LibWeb/DOM/MutationObserver.cpp b/Userland/Libraries/LibWeb/DOM/MutationObserver.cpp index 915c74ba83..5d587e246f 100644 --- a/Userland/Libraries/LibWeb/DOM/MutationObserver.cpp +++ b/Userland/Libraries/LibWeb/DOM/MutationObserver.cpp @@ -11,9 +11,9 @@ namespace Web::DOM { -JS::NonnullGCPtr MutationObserver::construct_impl(JS::Realm& realm, JS::GCPtr callback) +WebIDL::ExceptionOr> MutationObserver::construct_impl(JS::Realm& realm, JS::GCPtr callback) { - return realm.heap().allocate(realm, realm, callback).release_allocated_value_but_fixme_should_propagate_errors(); + return MUST_OR_THROW_OOM(realm.heap().allocate(realm, realm, callback)); } // https://dom.spec.whatwg.org/#dom-mutationobserver-mutationobserver diff --git a/Userland/Libraries/LibWeb/DOM/MutationObserver.h b/Userland/Libraries/LibWeb/DOM/MutationObserver.h index f12d1b4c48..9a61f6750d 100644 --- a/Userland/Libraries/LibWeb/DOM/MutationObserver.h +++ b/Userland/Libraries/LibWeb/DOM/MutationObserver.h @@ -32,7 +32,7 @@ class MutationObserver final : public Bindings::PlatformObject { WEB_PLATFORM_OBJECT(MutationObserver, Bindings::PlatformObject); public: - static JS::NonnullGCPtr construct_impl(JS::Realm&, JS::GCPtr); + static WebIDL::ExceptionOr> construct_impl(JS::Realm&, JS::GCPtr); virtual ~MutationObserver() override; WebIDL::ExceptionOr observe(Node& target, MutationObserverInit options = {});