RGBCube/serenity
1
Fork 0
mirror of https://github.com/RGBCube/serenity synced 2025-07-26 10:07:44 +00:00
Code Issues Activity Actions

LibWeb: Identical sub-expression bug in URLSearchParams::set

Browse source 
Flagged by sonarcloud, we appear to want to make sure the entry.name
matches the name we are searching for duplicates of.

Link:
https://sonarcloud.io/project/issues?fileUuids=AXvdC606QRvsO1F91p5C&id=SerenityOS_serenity&open=AXvdC_NEQRvsO1F91p6j
This commit is contained in:
Brian Gianforcaro 2021-09-12 21:12:21 -07:00 • committed by Brian Gianforcaro
parent fc1b9288bc
commit 7852b0fbc3
1 changed files with 1 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
Userland/Libraries/LibWeb/URL/URLSearchParams.cpp
View file

@ -88,7 +88,7 @@ void URLSearchParams::set(const String& name, const String& value)
if (!existing.is_end()) { if (!existing.is_end()) {
existing->value = value; existing->value = value;
m_list.remove_all_matching([&name, &existing](auto& entry) { m_list.remove_all_matching([&name, &existing](auto& entry) {
return &entry != &*existing && name == name; return &entry != &*existing && entry.name == name;
}); });
} }
// 2. Otherwise, append a new name-value pair whose name is name and value is value, to this’s list. // 2. Otherwise, append a new name-value pair whose name is name and value is value, to this’s list.